Add Plotly custom mimetype to NB outputs. #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kully
reviewed
Mar 15, 2017
| 'text/html': script_inject, | ||
| 'text/vnd.plotly.v1+html': script_inject | ||
| } | ||
| ipython_display.display(display_bundle, raw=True) |
There was a problem hiding this comment.
@Kully :
From IPython Docs:
raw : bool
Are the data objects raw data or Python objects that need to be formatted before display? [default: False]
We dont want IPython to do any further processing on this, so we use raw=True.
|
@tarzzz Okay Tarun, it's clearer now how this is supposed to work based on the code. Just have that one comment but the rest looks fine to me. |
|
@Kully : We will also need to release a new version for this change, so that the users can do a pip upgrade and be able to use it with |
|
@cldougl : Updated Changelog and version .. 👍 |
|
lgtm 💃 after tests pass |
|
Great, merging!! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure notebooks sanitize HTML when the user requests to 'Download as HTML'. This leads to Plotly Charts being rendered in plain text. To tackle the same, we send the Plotly chart data as a custom mimetype:
text/vnd.plotly.v1+html.PlotlyHTMLExporter (Plotly friendly, Jupyter Notebook HTML Exporter) recognizes this
mimetype, and renders the charts in their interactive version when notebook is converted to HTML.
PlotlyHTMLExportersanitizes all html content but leaves Plotly Charts intact.